Fix Code becoming integer. #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add separate workflow for testing on Python 3.6 as this requires an older Ubuntu release. Fixup unit tests for compatibility with newer versions of mock. Drop latest/stable functional test targets - this is actually 2.9.x of Juju and is already covered by the 2.9 targets and we want to avoid suddenly picking up a new Juju version because this will break with the new approach to version alignment in the Python module for Juju. Drop 2.8 functional test target - its broken and we don't really support this version any longer. Fixup iptables forwarding issues from LXD containers with a flush and re-create of rules. (cherry picked from commit 9277a94)
…t-fixes Misc fixes for failing github workflows
Juju is pinned to <3.0 earlier. This patch pins the juju version to <3.2 so that libjuju 3.1 version is used. Modified run_on_unit to wait for completion and update results based on output.
Update channel in github workflows to use Juju 3.1. Drop --no-gui flag usage as this is the default now.
Update model configuration default-series to focal. Drop --classic flag for Juju installation.
When juju is strictly confined, random temp directories under /tmp are not accessible - render any templated bundle files under $HOME instead as this should be readable.
Pin juju upper constraint to <3.2
Add a wrapper to the scale command so k8s applications can be scaled in and out. (cherry picked from commit 05cd81d)
…bjuju3.1 Add helper for scaling k8s charms
Value of the Code key in the returned Dict is str in master branch. However while trying to get compatible with juju 3.x series it became int. Now it is not conforming to the function signature. Also there are usages in some tests so it reverted back to str.
freyes
force-pushed
the
issues/545
branch
2 times, most recently
from
b46dc7a to
c42c965
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value of the Code key in the returned Dict is str in master branch. However while trying to get compatible with juju 3.x series it became int. Now it is not conforming to the function signature. Also there are usages in some tests so it reverted back to str.