Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/replace font remove dropdown #30

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

shannonwells
Copy link

@shannonwells shannonwells commented Oct 8, 2024

Goal

The goal of this PR is to replace all fonts with Poppins (a Google font) and to remove dropdowns for choosing the network and chain since we have only one faucet. We will never support a faucet for another network besides Frequency and if we support another Frequency chain we can add a selection for that later.

Closes #20
Closes #21

Discussion

I chose to pull the typeface from Google servers instead of checking it into our code.

Checklist

  • PR Self-Review and Commenting
  • Tests updated

How To Test the Changes

  1. Clone the pr branch
  2. Launch a local frequency chain instance with make start
  3. Launch the faucet server:
git checkout feat/replace-font-remove-dropdown
yarn install --frozen-lockfile
yarn dev
  1. Launch the faucet client:
cd client
yarn install --frozen-lockfile
yarn dev -- --open
  1. Verify that the font has changed to Poppins
  2. Verify that there are no dropdowns to select a network or chain
  3. Verify that you can successfully get token from the faucet (local chain)

@shannonwells shannonwells force-pushed the feat/replace-font-remove-dropdown branch from 208da51 to 8861fab Compare October 8, 2024 19:22
@shannonwells shannonwells marked this pull request as ready for review October 8, 2024 19:23
Copy link

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@shannonwells shannonwells merged commit 2229797 into main Oct 8, 2024
6 checks passed
@shannonwells shannonwells deleted the feat/replace-font-remove-dropdown branch October 8, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Hide network change options (Was BUG: Network change not supported) Replace Fonts
3 participants