Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix faucet, better errors #23

Merged
merged 14 commits into from
Sep 18, 2024
Merged

Fix faucet, better errors #23

merged 14 commits into from
Sep 18, 2024

Conversation

shannonwells
Copy link

@shannonwells shannonwells commented Sep 17, 2024 •
edited
Loading

Problem

Needed a bit better errors, but really, needed to get the Paseo faucet working again.

Solution

  • update all @polkadot* packages
  • update any other needed packages because of that
  • make any necessary changes as a result
  • validate the address before calling fetch. If it's invalid, make a nice message.
  • Be smarter about detecting some errors.
  • Don't keep a .env file around

@shannonwells shannonwells changed the title Fix/better errors Fix faucet, better errors Sep 17, 2024
@shannonwells shannonwells marked this pull request as ready for review September 17, 2024 23:50
@shannonwells shannonwells marked this pull request as draft September 17, 2024 23:50
@shannonwells
fix some build and ci issues
39c1dc1
@shannonwells
update some packages and config
f0dbf7e
@shannonwells
Attempting to fix CI:
6cf6b6a 
* update workflows
* update svelte and postcss config for postcss new way
* restrict output to error only
* updates to some packages
@shannonwells
Merge branch 'fix/better-errors' of github.com:frequency-chain/testne…
155ee60 
…t-faucet into fix/better-errors
@shannonwells
update yarn.lock in client
c416826
@shannonwells
update env to fix CI errors
409e959
@shannonwells
Fixing CI:
f51b9e9 
* ignore test-results
* add env.sample
* fix faucet tests
* put back order of verify-pr commands
* updated client yarn
* add the postcss preprocessor package
@shannonwells
env
ed21504
@shannonwells
copy env in Dockerfile too
634f2ef
@shannonwells shannonwells marked this pull request as ready for review September 18, 2024 18:39
wilwade
wilwade approved these changes Sep 18, 2024
View reviewed changes
Copy link

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

  • Read through code only

claireolmstead
claireolmstead approved these changes Sep 18, 2024
View reviewed changes
Copy link

@claireolmstead claireolmstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

aramikm
aramikm approved these changes Sep 18, 2024
View reviewed changes
Copy link

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for fixing this.

@shannonwells shannonwells merged commit f2fbf3a into main Sep 18, 2024
5 checks passed
@shannonwells shannonwells deleted the fix/better-errors branch September 18, 2024 19:59
@shannonwells
Copy link
Author

shannonwells commented Sep 18, 2024 •
edited
Loading

Related to #22 although there might be some other improvements to be made for error messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claireolmstead claireolmstead claireolmstead approved these changes

@aramikm aramikm aramikm approved these changes

@wilwade wilwade wilwade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shannonwells @wilwade @aramikm @claireolmstead