#1994 Error when stake is more than available stakable balance #2228
+25
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
saraswatpuneet
commented
Nov 21, 2024
| proposed_amount | ||
| } else { | ||
| Zero::zero() | ||
| } |
There was a problem hiding this comment.
At the calling end of this function a validation is to check if returned amount > 0 and a error is thrown then
github-actions
bot
added
the
metadata-changed
mattheworris
approved these changes
Nov 22, 2024
JoeCap08055
approved these changes
Nov 25, 2024
JoeCap08055
reviewed
Nov 25, 2024
github-actions
bot
added
metadata-changed
github-actions
bot
added
metadata-changed
wilwade
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to error out when stake is more than available stakable balance
Closes #1994
Discussion
Checklist