Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to mdbook v0.4.42 #118

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Switch to mdbook v0.4.42 #118

merged 3 commits into from
Nov 20, 2024

Conversation

wilwade
Copy link
Contributor

@wilwade wilwade commented Nov 19, 2024

Problem

v0.4.42 of mdBook changed a lot of things. This updates to v0.4.42 and tries to make it as easy as possible to upgrade in the future by making minimal changes to the core css.

Closes #117

Testing: It should look and interact the same as the live site with the following exceptions:

  • Slight margin tweaks
  • Added paragraph padding

@wilwade wilwade marked this pull request as ready for review November 20, 2024 14:36
Copy link
Contributor

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran locally with mdbook v0.4.42 and the site looks correct

@wilwade wilwade merged commit 9e5b759 into main Nov 20, 2024
3 checks passed
@wilwade wilwade deleted the chore/update-mdbook branch November 20, 2024 15:50
wilwade added a commit that referenced this pull request Nov 20, 2024
Bug fix from #118 

- Remove dup js that was causing expansion issues
- Fix table styles (although we don't currently have any tables)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to mdBook v0.4.42+
2 participants