-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Manifest v3 #75
Use Manifest v3 #75
Conversation
My bad, bad mouse clicks.
Is there a tool out there that does manifest v2 generation from a manifest v3 configuration? That should still help with having two deployments to different stores. |
Not that I know of. Currently it's impossible to use this template for Chrome so it's best to make the switch regardless of Firefox support (which is a small percentage of users) |
Firefox user here 😛 . It'd make me sad to see FF support dropped leaving me with no options for starting new extensions 🙁. I think having 2 manifests and 2 separate build commands that use those as entry points can be an option? what @notlmn mentions (generating one version from another, or generating both versions from a common template) would be ideal, but just having 2 manifests should be an easy option to start with? |
Indeed you can do that after using the template, but here it would mean duplicating every build command and the manifest itself, it's a mess. I assume Firefox is only a couple of months away from allowing MV3 |
Aren't templates meant to make life with messes easier? 😅 |
Also, I think not all commands, but just the |
True, but you're assuming that what you're suggesting is easier, which it isn't. For a starter,
The second run gets:
So what's the alternative?
At this point, if Firefox support is paramount, then I suggest going with a Webpack-based build like https://github.com/aeksco/react-typescript-web-extension-starter |
We've fixed |
@fregante will experiment with different folders for manifest approach which seems like it can be ok and let you know how it goes! |
@101arrowz thank you for the comment! From my understanding the latest version is broken for content scripts?
FF completely fails to load MV3 extensions, this is not a Parcel issue unfortunately; |
@fregante double-folder approach works btw, see manifest and package.json changes in transclude-me/extension@78b529e |
I'm hitting a weird bug with bundling though. It does not seem to be related to the double folder approach, but started happenign to me after 2.5 upgrade: parcel-bundler/parcel#8071 |
This commit appears to mix adding the double-folder approach together with a bunch of changes specific to your extension - right? Any chance you could summarise just the generic double-folder changes needed? |
That’s correct. Summary is:
|
Please continue in #78 |
This drops support for Firefox 🤷♂️