Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the CI + workflow for deploying contracts to testnet #150

Merged
merged 55 commits into from
Dec 5, 2024

Conversation

konnov
Copy link
Contributor

@konnov konnov commented Nov 29, 2024

I did not expect that it will take me so much time (like a week) to fix the CI with all the recent Soroban changes. What we have here:

  • An update to stellar/rs-soroban-sdk 22.0.0-rc.3.1 in the examples
  • An update to @stellar/stellar-sdk v13.0
  • A downgrade to rustc 1.81.0, otherwise, a few examples break on deployment with references-something-we-love-rust, see Rust 1.82+ enables reference-types / multivalue wasm target features stellar/rs-soroban-env#1469.
  • The deployment scripts fixed and working with v22.0.0 on the testnet
  • Calling __constructor instead of initialize in timelock, since cap-0058
  • Since the Horizon API does not have result_meta_xdr any longer (two weeks earlier than announced), using getTransaction from the rpc.Server. Now we use both Horizon API and RPC API. Perhaps, we could switch to RPC completely in the future.
  • Add workflow testnet.yml to deploy all the contracts we use, including the old version of xycloans. This workflow is only triggered on-demand or once per week, so we don't have to spam the testnet on every commit.

Optimally, it would be great to have a smaller PR, but all these things pulled one another.

@konnov konnov changed the title add a workflow for deploying contracts to testnet fixing the CI + workflow for deploying contracts to testnet Dec 4, 2024
@konnov konnov marked this pull request as ready for review December 4, 2024 18:09
Copy link
Collaborator

@thpani thpani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for taking care of this! 🙏🏻

I just have a few small questions about small fragments that aren't clear:

ContractExamples/.cargo/config.toml Outdated Show resolved Hide resolved
ContractExamples/Cargo.toml Outdated Show resolved Hide resolved
ContractExamples/Cargo.toml Outdated Show resolved Hide resolved
ContractExamples/scripts/prepare-timelock.sh Outdated Show resolved Hide resolved
ContractExamples/scripts/xycloans-populate.sh Outdated Show resolved Hide resolved
ContractExamples/scripts/xycloans-populate.sh Outdated Show resolved Hide resolved
solarkraft/package.json Outdated Show resolved Hide resolved
solarkraft/src/fetcher/callDecoder.ts Show resolved Hide resolved
@konnov konnov merged commit 2d55c7a into main Dec 5, 2024
3 checks passed
@konnov konnov deleted the igor/contract-setup branch December 5, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants