Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremely optimize PNG image assets losslessly #406

Merged

Conversation

PeterDaveHello
Copy link
Contributor

Use Google's zopflipng for extreme lossless PNG image optimization. This optimization significantly reduced PNG file sizes while maintaining the image quality.

@joggee-fr
Copy link
Contributor

Maybe it would be nice to migrate to vector drawables for simple icons. It avoids playing with all these dpi directories / variants.

@joggee-fr
Copy link
Contributor

@justin-stephenson, looking at the code, ic_edit is the only icon with PNG in dpi-variant directories. A vector drawable is also available in drawable-anydpi. Do you know if it is a miss?
Other icons just like ic_add are only exisiting in drawable directory as a vector drawable.

@justin-stephenson
Copy link
Contributor

@PeterDaveHello Could you please rebase now that #407 was merged to master?

@PeterDaveHello
Copy link
Contributor Author

Sure, let me do it.

Use Google's zopflipng for extreme lossless PNG image optimization. This
optimization significantly reduced PNG file sizes while maintaining the
image quality.
@justin-stephenson justin-stephenson merged commit 4ab9a44 into freeotp:master Jul 22, 2024
2 checks passed
@PeterDaveHello PeterDaveHello deleted the OptimizeImageAssets branch July 22, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants