Several minor changes for UI and extra stuff #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "app_welcome" as a new string resource for this purpose. BTW, add the translation for this new resource in French.
And move away app bar from the scroll view. It is already the case in main activity for example. Also remove ConstraintLayout nesting Button which seems a bit superfluous.
It should fix display issue for small screens. Position of the Done button has also been changed, moving from stuck to bottom right to simply bottom of content.
Add same behavior on long click on token item than click on its icon.
Hyperlink in backup fragment during on boarding was not correctly displayed. Use HtmlCompat.fromHtml() to create a spanned text to fix the issue.
With HtmlCompat.fromHtml() managing API level itself.
|
Thank you for the PR @joggee-fr - Please allow me some time to test the changes and UI flows. |
|
@joggee-fr Changes tested locally and look good to me, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I would like to propose some modifications to the application.
tools:listitemin main activity RecyclerView to preview the screen in Android Studio with item layout.Speaking of Toolbars, anybody know why they are nested in AppBarLayouts? I understand it could be interesting to add scrolling gestures but I can't see where such a feature is used in the FreeOTP application.
Let me know if you want me to split these commits in several PRs instead.
Thanks.