-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add French translation #363
Add French translation #363
Conversation
Thank you for the PR.
If no more changes are needed I will go ahead and merge this, just let me know. |
@justin-stephenson, thanks for the detail. |
<string name="get_started">COMMENCER</string> | ||
|
||
<!-- Strings for Backup related operations --> | ||
<string name="backup_title">Sauvgarder</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sauvegarder
<string name="restore_title">Restaurer</string> | ||
<string name="backup_restore_title">Sauvegarde et restauration</string> | ||
<string name="keystore_migration_explanation">Les jetons FreeOTP ont désormais migré vers le magasin de clés Anroid\u00A0! Il en résulte une sécurité accrue, mais les clés ne sont alors plus exportables. \n\nLes fonctionnalités de sauvegarde et restauration sont désormais ajoutées afin d\'assurer la récupération des jetons. Vous serez invité à créer un mot de passe maitre pour initialiser les sauvegardes chiffrées des jetons.</string> | ||
<string name="manual_backup_explanation">Parallèlement, un fichier de sauvegarde chiffré peut être exporté sur le stockage externe depuis l\'applicationan. La barre d\'outils supérieure contient désormais les entrées nommées \'Sauvegarde\' et \'Restauration\' afin d\'effectuer cette sauvegarde manuelle.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... depuis l'application.
Hello I've just translated the file in Corsican but I have good knowledges in French ;-) In my opinion, there is no problem to translate issuer by « Fournisseur ». I noticed a couple of typos on lines 114 and 118 and I added a comment on your file. Best regards, |
Thanks for your review @Patriccollu. @justin-stephenson, my proposal is now ready to be merged if you are OK with it. |
Hi. Sorry for the late reply. I confirmed the changes suggested by @Patriccollu. Here are some more typos I found in mobile/src/main/res/values-fr/strings.xml:
|
Thanks @futal.
As I understant it, lines 120 and 121 are content description for images (just like alt property for HTML tag img for example). I don't think they are really displayed but could be nice for accessibility, screen reader and stuff like this. |
Then lines 120 and 121 are fine for alt properties (it is not clear out of context as there are no uppercase after "Image" but they become clear as alt tags which are usually pronounced with a different voice and the upper case does not matter there). |
Thanks again for yours reviews @Patriccollu and @futal. |
This is my proposal to add a French translation to FreeOTP.
I sometimes had to not stick to the English base sentences to make it clearer in French.
BTW, is there difference between "issuer" and "provider"? I decided to stay with "fournisseur" in French which is closer to "provider". A possible translation for "issuer" could be "émetteur".