Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With escaped apostrophes version of Italian translation by @anthologist #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

byjosh
Copy link

@byjosh byjosh commented Sep 29, 2020

This is #184 by @anthologist (https://github.com/anthologist) except the unescaped apostrophes are now escaped as suggested by @dvanbalen (https://github.com/dvanbalen ) .

It seemed the lack of a few escaping backslashes were all that was holding this Italian translation up - so I've done those.

As pull requests are under Apache License https://github.com/freeotp/freeotp-android/blob/master/COPYING I think this is fine - as I am clear about who deserves credit for the actual translation (I'm just the backslash guy).



This is freeotp#184 by @anthologist (https://github.com/anthologist) except the unescaped apostrophes are now escaped as suggested by @dvanbalen (https://github.com/dvanbalen ) . It seemed the lack of a few escaping backslashes were all that was holding this Italian translation up - so I've done those. As pull requests are under Apache License https://github.com/freeotp/freeotp-android/blob/master/COPYING I think this is fine - as I am clear about who deserves credit for the actual translation (I'm just the backslash guy).
@dvanbalen
Copy link
Collaborator

Thanks, @byjosh

Further merging of translations is temporarily on hold until some refactoring is completed within the repository. At that point, it should get merged. Thanks, everyone, for their patience.

@byjosh
Copy link
Author

byjosh commented Sep 29, 2020

Thanks for explanation @dvanbalen (looking at date of last request I thought it might have been one of those "small things left by busy people").

Not sure if you are the person (nor this the place) but will mention #242 while I'm here - it would make significant usability improvement for new users doing key addition for an insignificant amount of change (2 lines) - and, while the refactoring would likely fix issue & more besides; if build -> App Store is fairly automated & quick then it seems a very easy win for new users in the meantime (which might last some time).
Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants