Add token sharing support, including Jelling support #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joekir Can you review this? |
|
@npmccallum that CI failure is from the gradle config updates that we still need to do. I'll try review it this week at some point if that's ok? |
Now you can choose to "share" a token to another source. This commit contains only the sharing framework. Specific sharing targets will follow in future commits.
Now, copying a code to the clipboard is manual (though still trivial). This increases security and has equal discoverability. Fixes freeotp#58 Fixes freeotp#63 Fixes freeotp#49
If you grant permissions, FreeOTP can now scan for Jelling targets. If one is found, you can share your token with it. On the Jelling side, the token will be typed as if you had manually typed it.
|
@joekir I fixed the build in master and rebased this patch. This week would be great. |
joekir
reviewed
Dec 18, 2017
|
|
||
| @Override | ||
| public void onConnectionStateChange(BluetoothGatt gatt, int status, int state) { | ||
| switch (state) { |
There was a problem hiding this comment.
Should there be a default case, e.g. to log an unknown state?
joekir
approved these changes
Dec 18, 2017
joekir
approved these changes
Dec 18, 2017
|
@npmccallum my review doesn't seem to have changed the state. Most likely as I don't have write access. Over to you to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the patches: