Home screen widget #100
Home screen widget #100
Conversation
|
@ericbrandwein Can you rebase this patch? Thanks! |
ericbrandwein
force-pushed
the
master
branch
from
781c71e to
b2c799a
Compare
|
Done! If you want to change something about the widget, please let me know, or merge this to a temporary branch and edit it from there. |
|
Something I'd love is the ability like on the phone app where you can drag a shortcut for dialing a specific user, I'd love to be able to drag a specific shortcut for a particular code onto the home screen, where I can then click it and it will just pop up a notification with my code. |
|
@ericbrandwein This PR causes one of our tests to fail. Can you please address that? |
| import android.widget.Toast; | ||
|
|
||
| /** | ||
| * Created by root on 18/04/17. |
There was a problem hiding this comment.
You are not root of this project 😄
| import java.util.Set; | ||
|
|
||
| /** | ||
| * Created by root on 17/04/17. |
| import java.io.IOException; | ||
|
|
||
| /** | ||
| * Created by root on 13/04/17. |
| final RemoteViews row = new RemoteViews(context.getPackageName(), R.layout.widget_row); | ||
|
|
||
| try { | ||
| Bitmap b = Picasso.with(context).load(token.getImage()).get(); |
There was a problem hiding this comment.
This not how to use Picasso. Calling .get() will block the thread instead of taking advantage of assynchronous call of Picasso.
You may:
- use
.error(R.drawable.logo)to handle the error (don't use try-catch when Picassso does it for you) - use
.into(row, R.id.widget_image, ...)to put the loaded image in the imageview
| android:layout_gravity="center_vertical" | ||
| android:textColor="@android:color/white" | ||
| android:layout_height="wrap_content" | ||
| android:text="@string/app_name"/> |
There was a problem hiding this comment.
Can you use drawableLeft directly in TextView instead of Linear+ImageView+TextView to draw a drawable on the left ?
Adds a widget that shows a list of the current tokens. I saw this feature in the Authy app and I liked it, so I decided to add it here.
Fixes #26.