ShortCaseCitation.full_span now includes parentheticals #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only
FullCaseCitation
objects included parentheticals and antecedent text in thefull_span
method.For example, in this
ShortCaseCitation
:However, if the same citation was a
FullCaseCitation
, what is included differs:I am working in an application that requires all
full_span
definitions to be more like the latter, so I've made a small set of changes toShortCaseCitation
,IdCitation
, andSupraCitation
.No existing tests seem to break, but I have not written new tests for the changed behavior.
If this is desired behavior; that is, if it would be helpful to harmonize these definitions by always including the parenthetical and antecedent, I can write some tests and clean this up a bit into a PR. Let me know if that would be helpful.