Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Refactor SMF consumer processor service #106

Merged
merged 33 commits into from
Jul 1, 2024
Merged

refactor: Refactor SMF consumer processor service #106

merged 33 commits into from
Jul 1, 2024

Conversation

ming-hsien
Copy link
Contributor

@ming-hsien ming-hsien commented May 8, 2024 •
edited
Loading

Refactor

Consumer

  • consumer
  • smf_service
  • nrf_Service
  • udm_service
  • chf_service
  • pcf_service

Server

  • copy server side code
  • implement server structure & refactor sbi_{SVC}.go
  • Add GetCertPemPath() & GetCertKeyPath()
  • Remove Legacy Code
  • RegisterNFInstance()

Processor

  • processor/processor.go

Testing

  • Test with UERANSIM (this is bullshit) and Packet Rusher

@andy89923 andy89923 changed the title Refactor: Refactor SMF consumer processor service refactor: Refactor SMF consumer processor service May 9, 2024
@ming-hsien ming-hsien force-pushed the refactor/sbi-logic branch from 7cc2136 to 2cf8281 Compare May 15, 2024 10:13
@ming-hsien ming-hsien marked this pull request as ready for review June 3, 2024 15:36
andy89923
andy89923 reviewed Jun 5, 2024
View reviewed changes
pkg/utils/pfcp_util.go Outdated Show resolved Hide resolved
internal/sbi/processor/processor.go Outdated Show resolved Hide resolved
internal/sbi/consumer/udm_service.go Outdated Show resolved Hide resolved
internal/context/ngap_handler.go Outdated Show resolved Hide resolved
internal/sbi/consumer/consumer.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved
@ming-hsien
Copy link
Contributor Author

Hi Andy. Thanks for your comment. I have made the corrections you suggested. Please help me check it. Thank you.

a3828162
a3828162 reviewed Jun 6, 2024
View reviewed changes
internal/sbi/api_callback.go Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
@pf-lin pf-lin force-pushed the refactor/sbi-logic branch from aaec76f to 376c4be Compare June 7, 2024 12:59
@andy89923 andy89923 mentioned this pull request Jun 8, 2024
Closed
andy89923
andy89923 reviewed Jun 21, 2024
View reviewed changes
internal/sbi/consumer/chf_service.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved
internal/sbi/api_pdusession.go Outdated Show resolved Hide resolved
internal/sbi/api_pdusession.go Outdated Show resolved Hide resolved
internal/sbi/api_pdusession.go Outdated Show resolved Hide resolved
internal/sbi/api_eventexposure.go Outdated Show resolved Hide resolved
internal/pfcp/reliable_pfcp_request_test.go Outdated Show resolved Hide resolved
@ianchen0119
Copy link
Contributor

Others look good to me.

@ianchen0119 ianchen0119 merged commit a50253f into free5gc:main Jul 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy89923 andy89923 andy89923 left review comments

@a3828162 a3828162 a3828162 approved these changes

@ianchen0119 ianchen0119 ianchen0119 approved these changes

@TYuan0816 TYuan0816 Awaiting requested review from TYuan0816

@ian-cs12-NYCU ian-cs12-NYCU Awaiting requested review from ian-cs12-NYCU

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ming-hsien @ianchen0119 @andy89923 @a3828162 @TYuan0816 @ian-cs12-NYCU @pf-lin