Apply suggestions from code review

Co-authored-by: Hugo van Kemenade <[email protected]>
freakboy3742 · Mar 21, 2024 · cf0b5ff · cf0b5ff
1 parent 9515f75
commit cf0b5ff
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/Doc/library/webbrowser.rst b/Doc/library/webbrowser.rst
@@ -189,7 +189,7 @@ Notes:
    Skipstone, Iceape, and Firefox versions 35 and below.
 
 .. versionchanged:: 3.13
-   Support for iOS was added.
+   Support for iOS has been added.
 
 Here are some simple examples::
 

diff --git a/Lib/_ios_support.py b/Lib/_ios_support.py
@@ -29,7 +29,7 @@ def get_platform_ios():
 
     # We can't use ctypes; abort
     if not objc:
-        return
+        return None
 
     # Most of the methods return ObjC objects
     objc.objc_msgSend.restype = c_void_p

diff --git a/Lib/site.py b/Lib/site.py
@@ -280,8 +280,8 @@ def _getuserbase():
     if env_base:
         return env_base
 
-    # iOS, tvOS, watchOS, Emscripten, VxWorks, and WASI have no home directories
-    if sys.platform in {"ios", "emscripten", "tvos", "vxworks", "wasi", "watchos"}:
+    # Emscripten, iOS, tvOS, VxWorks, WASI, and watchOS have no home directories
+    if sys.platform in {"emscripten", "ios", "tvos", "vxworks", "wasi", "watchos"}:
         return None
 
     def joinuser(*args):

diff --git a/Lib/sysconfig/__init__.py b/Lib/sysconfig/__init__.py
@@ -126,8 +126,8 @@ def _getuserbase():
     if env_base:
         return env_base
 
-    # iOS, tvOS, watchOS, Emscripten, VxWorks, and WASI have no home directories
-    if sys.platform in {"ios", "emscripten", "tvos", "vxworks", "wasi", "watchos"}:
+    # Emscripten, iOS, tvOS, VxWorks, WASI, and watchOS have no home directories
+    if sys.platform in {"emscripten", "ios", "tvos", "vxworks", "wasi", "watchos"}:
         return None
 
     def joinuser(*args):

diff --git a/Misc/NEWS.d/next/Library/2024-03-19-14-35-57.gh-issue-114099.siNSpK.rst b/Misc/NEWS.d/next/Library/2024-03-19-14-35-57.gh-issue-114099.siNSpK.rst
@@ -1 +1 @@
-Standard library was modified to allow for iOS platform differences.
+Modify standard library to allow for iOS platform differences.
diff --git a/Modules/getpath.py b/Modules/getpath.py
@@ -173,7 +173,7 @@
 
 platlibdir = config.get('platlibdir') or PLATLIBDIR
 
-if os_name == "posix" or os_name in {"darwin", "ios", "tvos", "watchos"}:
+if os_name in {"darwin", "ios", "posix", "tvos", "watchos"}:
     BUILDDIR_TXT = 'pybuilddir.txt'
     BUILD_LANDMARK = 'Modules/Setup.local'
     DEFAULT_PROGRAM_NAME = f'python{VERSION_MAJOR}'
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		Standard library was modified to allow for iOS platform differences.
		Modify standard library to allow for iOS platform differences.