Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-build-push.yml to support arm64 #1492

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

rexeo-asia
Copy link
Contributor

Please provide enough information so that others can review your pull request:
To include arm64 build in https://hub.docker.com/r/frappe/erpnext/tags

Explain the details for making this change. What existing problem does the pull request solve?
To support arm64 container image

@revant
Copy link
Collaborator

revant commented Oct 15, 2024

We'll be adding this PR to the list of slow builds

Read here: https://github.com/frappe/frappe_docker/wiki/Frequently-Asked-Questions#how-to-build-arm64-images

@revant revant closed this Oct 15, 2024
@revant revant reopened this Oct 15, 2024
@revant
Copy link
Collaborator

revant commented Oct 15, 2024

Should we just do the merge, fail and revert for the PR "Hall of fame"? OR close this without that?
Because the maintenance overhead is on me. (The merge, one release fail, I manually push failed release and revert, too much unnecessary steps)

  • It takes 2 hours for builds every time this PR comes up
  • Python Version for frappe and Debian APT get python is different, causing pip to build many things instead of just using ready binaries.
  • ARM runner required for this. It will speed up on ARM runner, Ubuntu/AMD64 runner takes 2+ hours for arm builds

@revant
Copy link
Collaborator

revant commented Oct 25, 2024

@rexeo-asia can you try it under your github/actions? can you re-check the build times? If there is any improvement after these years, we'll merge.

@revant
Copy link
Collaborator

revant commented Nov 11, 2024

c04ffb8

Seems to be building faster now. Will merge.

@revant revant merged commit 88ac021 into frappe:main Nov 11, 2024
2 checks passed
@revant
Copy link
Collaborator

revant commented Nov 13, 2024

#1511

@rexeo-asia arm64 images not pushed somehow.

@rexeo-asia
Copy link
Contributor Author

#1511

@rexeo-asia arm64 images not pushed somehow.

just added new PR for your review. thanks brother from another mother

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants