Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Align calculation of total games with the number of downloaded games. Closes #84 #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nevsor
Copy link

@Nevsor Nevsor commented Nov 11, 2023

Prevent the account cards from showing a percentage of downloaded games greater than 100% by aligning the calculation of games to the way games are downloaded.

grafik

I need to identify other causes of games missing in the total, before this PR is ready.

In AccountCards.tsx the downloaded games include correspondence games, so the number of total games should include these as well.
@franciscoBSalgueiro
Copy link
Owner

franciscoBSalgueiro commented Nov 11, 2023

Thanks, I don't play correspondence, so I didn't notice that it was missing on lichess.

The chess.com discrepancy is probably their problem tbh, even on their own site the counts don't add up.
For example:

On here it says that Daniel Naroditsky has played 133198 bullet games.
image
Here it says it's 52,954 games.
image
And here it says it's 35180
image
And if you go to the API it says it's 51,125
image

@Cankyre
Copy link
Contributor

Cankyre commented Nov 28, 2023

Well only games in the archive can actually be downloaded IIRC, so I'd say archive is the best number to use.
For stats some games randomly don't count, but unrated games definitely don't count.

Lichess seems to only have one game count though.

@CoderDen732
Copy link

Just to add this, repeatedly clicking download games and then refreshing causes the downloaded % to increase. This is true for both chess.com and lichess. This also skews the other stats such as win-loss%.
Screenshot 2024-03-14 233117
This is before spamming download.
Screenshot 2024-03-14 233928
This is after spamming

From this, I infer that the problem on both lichess and chess.com is not entirely due to inconsistencies in the number of games counted by the platform itself. This may, however, be a part of the problem

@franciscoBSalgueiro
Copy link
Owner

That's a different issue that was already fixed in the pre release

@buracchi
Copy link

The database obtained by downloading games from chess.com contains both the 'Live Chess' and 'Play vs Bot' categories (appearing under the 'Tournaments' tab).
Bot games are not used by chess.com to calculate the total number of games.
I also have more games in Live Chess than the total number of games, so something else does not add up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants