Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HRIS - 444] - [BUGTASK] Button is not display if user inputted long text from the field in Timein Modal #343

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Miguel21Monacillo
Copy link
Contributor

Issue Link

Backlog Link

Definition of Done

  • Users can now input long remarks on TimeIn Remarks, Breaktime Remarks, Logout Remarks and the "Save" button will not disappear.

Notes

  • I also fixed the issue where the icon for interruption goes to the bottom when the text inputted is too long

Pre-condition

Commands to run
Route links
Etc

Expected Output

The save button for the TimeIn, BreakTime, and TimeOut modal should not disappear if the inputted text on remarks is too long

Screenshots/Recordings

TimeIn
image

BreakTime
image

TimeOut
image

Copy link
Contributor

@Fontilllas Fontilllas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Approve

Testing.Time.In.Break.Time.Time.Out.buttons.is.not.displayed.mp4

Comments:
Testing Time: 2min
Iterations: 0

Copy link

@jonel371234 jonel371234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

  • Users can now input long remarks on TimeIn Remarks, Breaktime Remarks, Logout Remarks and the "Save" button will not disappear.
Screen.Recording.2024-11-19.173347.mp4

Comments: 0
Test Time: 5mins
Iterations: 0

@Fontilllas Fontilllas merged commit f359360 into develop Nov 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants