HRIS-361 [Task] Setup Nest.js under api_v2 folder

[mdv-sunasterisk]

Issue Link

Backlog Link

Definition of Done

• Setup Nest.js
• Connect to graph QL
• Setup Jest
• Setup Husky pre-commit

Notes

• Initial commit for the NestJS setup. Includes the necessary configuration to commence the slack API integration.

Pre-condition

• Run the usual docker commands to update the project. The docker-compose.yml, dockerfile, .dockerignore files have been created/updated accordingly for a seamless update.

Expected Output

• The NestJS project should be running on port 3001.

Screenshots/Recordings

Note: Minimal pre-commit alterations were added after the time of recording.

Screen.Recording.2024-06-07.at.1.11.27.PM.mov

[chevyB]

its good to have short command when running dev environment

Suggested change

	"start:dev": "nest start --watch",
	"start:debug": "nest start --debug --watch",
	"dev": "nest start --watch",
	"dev:debug": "nest start --debug --watch",

[chevyB]

much better if we follow strict implementation

Suggested change

	"strictNullChecks": false,
	"noImplicitAny": false,
	"strictNullChecks": true,
	"noImplicitAny": true,

[chevyB]

1. can we add ?

    "noUnusedLocals": true,
    "noUnusedParameters": true,

2. much better to also have alias
   "paths": { "@/*": ["src/*"] }

[chevyB]

Suggested change

	}
	}
	}
	"exclude": ["node_modules", "dist"]
	}

[chevyB]

i want to include npm run lint without fix in husky pre-commit.
So dev can know that there are lint errors to fix and can be familiarize about linting.

Suggested change

	"lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
	"lint": "eslint \"{src,apps,libs,test}/**/*.ts\"",
	"lint:fix": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",

[chevyB]

Suggested change

	# ASP.NET Service
	# NestJS Service

[chevyB]

Im just wondering what's the consideration why we containerized the api.
Its good that we have 1 command to run all servers but im worry if our laptops can handle many docker containers.
Is there is no difference about laptop performance running between npm run dev or using docker?

[mdv-sunasterisk]

I do agree that it feels heavy whenever i try running the docker compose command. Thought there was a deployment benefit to this as to why the previous team implemented this.

Personally, I run the docker compose command to run all of servers apart from api_v2, which i run locally using npm run dev.

May i ask for your thoughts? @chevyB

[chevyB]

I see, its ok to retain the docker configs but when running local, its beneficial to use npm run dev.
Let's update readme.md about using npm run dev in local.

[mdv-sunasterisk]

Got it, will apply changes.

[jeremiahC]

@mdv-sunasterisk @chevyB
Just additional note though, the purpose of containers or even for VM, is to create a separate environment that will not tamper the host machine. But I do agree that somehow docker does not have a good review in terms of performance in local environment.

I can agree to just run node in the host machine instead of docker. Docker will be more responsible on infra stuffs like DB.

[jeremiahC]

You can remove this container nalang

[jeremiahC]

ah wait, please keep this lang. I will be considering to deploy backend with docker. Sorry.

[mdv-sunasterisk]

Ok copy, we'll be retaining the api_v2 container. Kindly requesting for next actions @jeremiahC, and may I confirm if we're already good for merging?