Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stepper buttons from tab order #87

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ikanishakm
Copy link

What is this PR doing
This pull request adjusts the tab order for the Stepper component buttons by setting their tabIndex to -1. This change removes the increment and decrement buttons from the keyboard tab sequence, potentially improving navigation for keyboard users.

Testing

  • Verify tab order behavior

    • Open a page containing the Stepper component
    • Use the Tab key to navigate through the page
    • Confirm that focus skips over the increment and decrement buttons
    • Verify that focus moves directly from the input field to the next focusable element
  • Check button functionality

    • Click on the increment and decrement buttons with a mouse
    • Confirm that the buttons still function correctly when clicked
  • Keyboard accessibility check

    • Focus on the Stepper input field
    • Attempt to use arrow keys or other keyboard shortcuts to increment/decrement the value
    • Note any unexpected behavior or lack of keyboard control

Copy link

vercel bot commented Oct 16, 2024

@ikanishakm is attempting to deploy a commit to the Framer Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant