-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated installation instructions and refactored the exercise creation mecanism. #53
Open
plafrance
wants to merge
87
commits into
fracz:verifications
Choose a base branch
from
plafrance:main
base: verifications
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Among changes: - dockerfile triggers build of frontend and backend - php more configurable from docker/.env - removed some unused stuff - small readme on how to run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I finally came across this site and found it amazing! I have been looking for a while for a good learning tool for my students and this one was exactly what I needed. Thanks for this great tool!
Unfortunately, when the time came to create exercises of my own, I found it quite difficult. Working on different branches resulted complex and counter-intuitive to me. I fear that any change or correction made to an exercise required to force push and break everyone else's repo.
So I undertook the task of facilitating the process of creating exercises, as well as the installation process.
The changes I made are not small, I am afraid. But they allowed me to create 10 new exercises, as well as decoupling the main repo from the exercises repo, hence providing a french version of the exercises to my students.
Changes :
exercises
directory. The branches needed are created at buildtime from its content. There is no need to rewrite commits with every change anymore. Development history is linear.Caveat :
Whenever the containers are recreated (for instance, when adding a new exercise), all exercise branches are also recreated. The local repos will become out of sync with the server's. This can be fixed on the client-side by fetching the remote again (
git fetch origin
). Maybe there is a way of displaying a error message to the client whenever that situation occurs.I hope you will find those changes as useful as I found your exercises!
Thanks