-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added optional parameter open_array_kwargs to build_pyramid #895
Added optional parameter open_array_kwargs to build_pyramid #895
Conversation
…ssed as kwargs to zarr.open when creating the pyramid level arrays.
Thanks for the PR @m-albert , this change makes sense! The only potential issue is whether the overwrite functionality would break with this. I realize that our current test suite doesn't cover this case, so I'll add a small test for it |
Indeed, the old version raised |
@m-albert Can you have a look whether this version is fine for you? I now added explicit handling to make sure we fail if a pyramid level already exists, but overwrite is set to False. Besides that, it's just a bit of minor reformatting :) If you're happy with this, I'll merge this and make a fractal-tasks-core patch release out of it, so you can use it in the stitching task. |
Thanks a lot for looking into this so quickly @jluethi !
Oh right, I had completely missed this.
Thanks a lot for this, which looks good to me. And I just learned about the
Great, I'm very happy with this and will make use of the new functionality in the stitching task as soon as the patch release is out! |
@m-albert Great! I'll work on another small chunking-related fix, then I'll make a new release :) Thanks a lot for the PR! |
@m-albert fractal-tasks-core 1.4.1 with this change is now released :) |
… to be passed as kwargs to zarr.open when creating the pyramid level arrays.
Useful e.g. for passing
write_empty_chunks=True
.Fixes #894.
Checklist before merging
CHANGELOG.md