-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comply with table specs v1 #613
Conversation
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
…eter_original` when creating ROIs based on data
…and add dunder init
I'm starting to review this PR. One thing I noticed: |
Thanks! The same fix is now needed at least within |
And in create-ome-zarr-multiplex |
…create_ome_zarr_multiplex` tasks
Both fixed with 62ddae0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, our table writing is becoming much more structured.
The PR does open a few questions for me though, I wonder whether we can address them here as well:
Are we expecting most users of the API to provide the attrs or is this a special case? Are we building up the correct attrs when users don't provide them? So far, we are doing this in the individual tasks, right? Should we document more in the docstrings of the table writer functions what valid attrs are that we expect (/where to find that info)?
The attrs are often optional parameters, but core info like table_type seems to be in them.
When are there potential conflicts between attrs & other parameters? (see also #619) What takes precedence?
My overarching question: Which parameters should be exposed as function parameters and what goes into attrs? And are those attrs really optional?
Scenarios for type:
|
Let's also tackle this one here: #619 |
|
…name if needed (close #619)
Refs:
write_table
in registration tasks #594instance_key
column #617Close #593
Close #594
Close #602
Close #616
Close #617
Checklist before merging
CHANGELOG.md