Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support prometheus-client metrics exporter #805

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Nov 28, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

close #791

@MrCroxx MrCroxx added the feature New feature or request label Nov 28, 2024
@MrCroxx MrCroxx added this to the v0.13 milestone Nov 28, 2024
@MrCroxx MrCroxx self-assigned this Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
foyer-common/src/metrics/model.rs 100.00% <100.00%> (ø)
foyer-common/src/metrics/registry/noop.rs 100.00% <100.00%> (ø)
...-common/src/metrics/registry/opentelemetry_0_26.rs 100.00% <100.00%> (ø)
...-common/src/metrics/registry/opentelemetry_0_27.rs 100.00% <100.00%> (ø)
foyer-common/src/metrics/registry/prometheus.rs 98.29% <100.00%> (ø)
...mon/src/metrics/registry/prometheus_client_0_22.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@MrCroxx MrCroxx enabled auto-merge (squash) November 28, 2024 07:07
@MrCroxx MrCroxx merged commit 9321f60 into main Nov 28, 2024
24 checks passed
@MrCroxx MrCroxx deleted the xx/prometheus-client-exporter branch November 28, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat: support prometheus-client exporter
1 participant