Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix insert ephemeral #786

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: fix insert ephemeral #786

merged 1 commit into from
Nov 19, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Nov 19, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Remove the entry when the last ref is dropped (idempotently) if the entry is still ephemeral.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#785

@MrCroxx MrCroxx added the bug Something isn't working label Nov 19, 2024
@MrCroxx MrCroxx added this to the v0.13 milestone Nov 19, 2024
@MrCroxx MrCroxx self-assigned this Nov 19, 2024
@MrCroxx MrCroxx enabled auto-merge (squash) November 19, 2024 06:17
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 95.58824% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-memory/src/raw.rs 95.58% 3 Missing ⚠️
Files with missing lines Coverage Δ
foyer-memory/src/raw.rs 90.76% <95.58%> (+2.53%) ⬆️

... and 3 files with indirect coverage changes


🚨 Try these New Features:

@MrCroxx MrCroxx merged commit d633ae2 into main Nov 19, 2024
23 checks passed
@MrCroxx MrCroxx deleted the xx/fix-insert-ephemeral branch November 19, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant