fix: check if entry is in indexer first before remove for deposit

[MrCroxx]

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

Previously, when a deposit entry is released after no external reference, it will remove the key from the indexer without checking if the entry is still in it. When there is another insertion with the same key between a deposit entry is inserted and released, this behavior will mistakenly delete the new version of the key from the indexer. Then the new entry is not in the indexer but maybe in the eviction container, which breaks the assumptions and cause panic.

- if handle.base().is_deposit() {
+ if handle.base().is_in_indexer() && handle.base().is_deposit() {

To reproduce:

    #[test]
    fn test_deposit_replace() {
        let cache = lru(100);
        let e1 = cache.deposit(42, "wrong answer".to_string());
        let e2 = cache.insert(42, "answer".to_string());
        drop(e1);
        drop(e2);
        assert_eq!(cache.get(&42).unwrap().value(), "answer");
        assert_eq!(cache.usage(), 6);
    }

Checklist

• I have written the necessary rustdoc comments
• I have added the necessary unit tests and integration tests
• I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

fix #531
fix #525
risingwavelabs/risingwave#16869