Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #16

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Upgrade dependencies #16

merged 2 commits into from
Jul 24, 2018

Conversation

foaly-nr1
Copy link
Contributor

No description provided.

@@ -26,6 +26,7 @@ const nodeResolve = require('rollup-plugin-node-resolve');
const organiser = require('gulp-organiser');
const { curry } = require('lodash/fp');
const rename = require("gulp-rename");
const extensions = require("./extensions");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

return {
name: "extensions",

resolveId(importee, importer) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'concise methods' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

module.exports = function extensions({ extensions }) {
if (!extensions || !extensions.length) {
throw new Error(
`Must specify { extensions: [..] } as non-empty array!`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'template literal syntax' is only available in ES6 (use 'esversion: 6').

return null;
}

module.exports = function extensions({ extensions }) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).


// In case `file` is a folder name, we check if there is an
// index file in the folder
const indexPath = `${file}/index${ext}`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'template literal syntax' is only available in ES6 (use 'esversion: 6').

const files = fs.readdirSync(dirname(file));

if (~files.indexOf(name) && isFile(file)) return file;
for (const ext of extensions) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'for of' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

function addExtensionIfNecessary(file, extensions) {
try {
const name = basename(file);
const files = fs.readdirSync(dirname(file));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).


function addExtensionIfNecessary(file, extensions) {
try {
const name = basename(file);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

*/

const { basename, dirname, isAbsolute, resolve } = require("path");
const fs = require("fs");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

Most of this file's code was taken from here: https://github.com/rollup/rollup/issues/1052
*/

const { basename, dirname, isAbsolute, resolve } = require("path");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

@foaly-nr1 foaly-nr1 merged commit 532514d into master Jul 24, 2018
@foaly-nr1 foaly-nr1 deleted the upgrade branch July 24, 2018 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants