-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert CompendiumBrowser to ApplicationV2 #16884
Convert CompendiumBrowser to ApplicationV2 #16884
Conversation
shoulda said something. Shark started experimentation into svelte. Compendium Browser is an amazing chance to try it out. |
yeah I wanted to wait for svelte support initially but the version 5 release has taken so long that I thought it made sense to convert to the handlebars renderer first. Switching out the renderer later should be relatively straight forward. |
But if that isn't something you want to do I can keep this in a stash until svelte is ready. It definitely helped me to better understand ApplicationV2 so it wasn't for nothing. |
20fce2c
to
9d9c9eb
Compare
I'll yoink the basic svelte stuff from the other PR and try it out for this. Converted to a draft in the meantime. |
As part of a rewrite, I think it would be neat if its possible to separate browsing actors from browsing items when launching from the actors or items tab. At the very least feats shouldn't be viewable from clicking the bestiaries browser imo. |
9d9c9eb
to
cccd223
Compare
I've pushed the svelte browser and updated the description with new infos and current screenshots. The changed file count just kept rising, sorry. 🙃 |
34b36ff
to
ee6ef1c
Compare
c9af5fc
to
1245667
Compare
d435b3f
to
29b2c15
Compare
29b2c15
to
45c3bb4
Compare
aa8f8aa
to
889204c
Compare
c5a7517
to
43546ff
Compare
f1ea150
to
1891021
Compare
1891021
to
848f35f
Compare
c961fc6
to
3169762
Compare
{#each Object.entries(filter.checkboxes) as [key, checkbox]} | ||
<FilterContainer | ||
isExpanded={checkbox.isExpanded} | ||
clearButton={{ data: checkbox, options: { visible: checkbox.selected.length > 0 } }} | ||
label={checkbox.label} | ||
> | ||
<Checkboxes bind:checkbox={filter.checkboxes[key as keyof BrowserFilter["checkboxes"]]} /> | ||
</FilterContainer> | ||
{/each} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R.entries
adds anever[]
here for some reason so I resorted to type assertion. A union type of all checkbox filters does not include never
so I'm not really sure what's going on there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with converting everything to Record<"string" | "unions", CheckboxData> but that doesn't seem to work at all. Seems to be an issue with R.entries's implementation on a union of records with explicit keys.
en.json
Some filter changes:
multiselects
andsliders
from the filter as they were unused except for thetraits
andlevel
filterstraits
andlevel
are now top level filter data.level
filter now renders as two select elements for min and maxControls:
Level filter:
Light:
Dark: