Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Simon Ward <[email protected]>
  • Loading branch information
ammalagonc and simonward authored Oct 15, 2024
1 parent d3e572d commit be8fb0f
Show file tree
Hide file tree
Showing 15 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion packs/equipment-effects/effect-fury-cocktail-greater.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"name": "Effect: Fury Cocktail (Greater)",
"system": {
"description": {
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Fury Cocktail (Greater)]</p>\n<p><strong>Benefit</strong> You gain a +4 item bonus to melee attack rolls and an additional effect depending on the additive chosen when the brew is created.</p><ul><li><strong>Animalistic</strong> choice between a jaws attack that deals 1d6 piercing damage or a claw attack that has the agile trait and deals 1d4 slashing damage.</li><li><strong>Double</strong> resistance 5 to physical damage</li><li><strong>Mournful</strong> resistance 10 to void or vitality depending on negative healing</li><li><strong>Skeptical</strong> +3 item bonus to saves against magic</li><li><strong>Titanic</strong> size change to Large, Clumsy 1, and change of reach (+5 for Medium and Small, +10 for Tiny)</li><li><strong>Wyrmhide</strong> resistance 10 to acid, cold, electricity, fire, and poison.</li></ul><p><strong>Drawback</strong> You take a –1 penalty to AC and a –2 penalty to Reflex saves.</p>"
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Fury Cocktail (Greater)]</p>\n<p><strong>Benefit</strong> You gain a +4 item bonus to melee attack rolls and an additional effect depending on the additive chosen when the brew is created.</p><ul><li><strong>Animalistic</strong> choice between a jaws attack that deals 1d6 piercing damage or a claw attack that has the agile trait and deals 1d4 slashing damage.</li><li><strong>Double</strong> resistance 5 to physical damage</li><li><strong>Mournful</strong> resistance 10 to void or vitality depending on void healing</li><li><strong>Skeptical</strong> +3 item bonus to saves against magic</li><li><strong>Titanic</strong> size change to Large, Clumsy 1, and change of reach (+5 for Medium and Small, +10 for Tiny)</li><li><strong>Wyrmhide</strong> resistance 10 to acid, cold, electricity, fire, and poison.</li></ul><p><strong>Drawback</strong> You take a –1 penalty to AC and a –2 penalty to Reflex saves.</p>"
},
"duration": {
"expiry": "turn-start",
Expand Down
2 changes: 1 addition & 1 deletion packs/equipment-effects/effect-fury-cocktail-lesser.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"name": "Effect: Fury Cocktail (Lesser)",
"system": {
"description": {
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Fury Cocktail (Lesser)]</p>\n<p><strong>Benefit</strong> You gain a +2 item bonus to melee attack rolls and an additional effect depending on the additive chosen when the brew is created.</p><ul><li><strong>Animalistic</strong> choice between a jaws attack that deals 1d6 piercing damage or a claw attack that has the agile trait and deals 1d4 slashing damage.</li><li><strong>Double</strong> resistance 1 to physical damage</li><li><strong>Mournful</strong> resistance 1 to void or vitality depending on negative healing</li><li><strong>Skeptical</strong> +1 item bonus to saves against magic</li><li><strong>Titanic</strong> size change to Large, Clumsy 1, and change of reach (+5 for Medium and Small, +10 for Tiny)</li><li><strong>Wyrmhide</strong> resistance 1 to acid, cold, electricity, fire, and poison.</li></ul><p><strong>Drawback</strong> You take a –1 penalty to AC and a –2 penalty to Reflex saves.</p>"
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Fury Cocktail (Lesser)]</p>\n<p><strong>Benefit</strong> You gain a +2 item bonus to melee attack rolls and an additional effect depending on the additive chosen when the brew is created.</p><ul><li><strong>Animalistic</strong> choice between a jaws attack that deals 1d6 piercing damage or a claw attack that has the agile trait and deals 1d4 slashing damage.</li><li><strong>Double</strong> resistance 1 to physical damage</li><li><strong>Mournful</strong> resistance 1 to void or vitality depending on void healing</li><li><strong>Skeptical</strong> +1 item bonus to saves against magic</li><li><strong>Titanic</strong> size change to Large, Clumsy 1, and change of reach (+5 for Medium and Small, +10 for Tiny)</li><li><strong>Wyrmhide</strong> resistance 1 to acid, cold, electricity, fire, and poison.</li></ul><p><strong>Drawback</strong> You take a –1 penalty to AC and a –2 penalty to Reflex saves.</p>"
},
"duration": {
"expiry": "turn-start",
Expand Down
2 changes: 1 addition & 1 deletion packs/equipment-effects/effect-fury-cocktail-moderate.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"name": "Effect: Fury Cocktail (Moderate)",
"system": {
"description": {
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Fury Cocktail (Moderate)]</p>\n<p><strong>Benefit</strong> You gain a +3 item bonus to melee attack rolls and an additional effect depending on the additive chosen when the brew is created.</p><ul><li><strong>Animalistic</strong> choice between a jaws attack that deals 1d6 piercing damage or a claw attack that has the agile trait and deals 1d4 slashing damage.</li><li><strong>Double</strong> resistance 2 to physical damage</li><li><strong>Mournful</strong> resistance 5 to void or vitality depending on negative healing</li><li><strong>Skeptical</strong> +3 item bonus to saves against magic</li><li><strong>Titanic</strong> size change to Large, Clumsy 1, and change of reach (+5 for Medium and Small, +10 for Tiny)</li><li><strong>Wyrmhide</strong> resistance 5 to acid, cold, electricity, fire, and poison.</li></ul>"
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Fury Cocktail (Moderate)]</p>\n<p><strong>Benefit</strong> You gain a +3 item bonus to melee attack rolls and an additional effect depending on the additive chosen when the brew is created.</p><ul><li><strong>Animalistic</strong> choice between a jaws attack that deals 1d6 piercing damage or a claw attack that has the agile trait and deals 1d4 slashing damage.</li><li><strong>Double</strong> resistance 2 to physical damage</li><li><strong>Mournful</strong> resistance 5 to void or vitality depending on void healing</li><li><strong>Skeptical</strong> +3 item bonus to saves against magic</li><li><strong>Titanic</strong> size change to Large, Clumsy 1, and change of reach (+5 for Medium and Small, +10 for Tiny)</li><li><strong>Wyrmhide</strong> resistance 5 to acid, cold, electricity, fire, and poison.</li></ul>"
},
"duration": {
"expiry": "turn-start",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"name": "Effect: Glittering Snare (Critical Failure)",
"system": {
"description": {
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Glittering Snare]</p>\n<p>You take -4 status penalty to Stealth checks. The glitter continues to fall around the creature until completely removed, leaving a trail behind it as it moves and revealing its rough location; the creature is @UUID[Compendium.pf2e.conditionitems.Item.Hidden], rather than @UUID[Compendium.pf2e.conditionitems.Item.Undetected], to any creature that can see the glitter whenever it would otherwise have been undetected.</p>"
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Glittering Snare]</p>\n<p>You take -4 status penalty to Stealth checks.</p>"
},
"duration": {
"expiry": "turn-end",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"name": "Effect: Glittering Snare (Failure)",
"system": {
"description": {
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Glittering Snare]</p>\n<p>You take a -2 status penalty to Stealth checks for the duration. If the creature was @UUID[Compendium.pf2e.conditionitems.Item.Invisible], the glitter outlines it for 1 round, making it @UUID[Compendium.pf2e.conditionitems.Item.Concealed] rather than @UUID[Compendium.pf2e.conditionitems.Item.Undetected] to visual senses.</p>"
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Glittering Snare]</p>\n<p>You take a -2 status penalty to Stealth checks.</p>"
},
"duration": {
"expiry": "turn-end",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"name": "Effect: Glittering Snare (Success)",
"system": {
"description": {
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Glittering Snare]</p>\n<p>The creature takes a -1 status penalty to Stealth checks.</p>"
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Glittering Snare]</p>\n<p>You take a -1 status penalty to Stealth checks.</p>"
},
"duration": {
"expiry": "turn-end",
Expand Down
2 changes: 1 addition & 1 deletion packs/equipment-effects/effect-goo-grenade.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"name": "Effect: Goo Grenade",
"system": {
"description": {
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Goo Grenade (Lesser)], @UUID[Compendium.pf2e.equipment-srd.Item.Goo Grenade (Moderate)], @UUID[Compendium.pf2e.equipment-srd.Item.Goo Grenade (Greater)], @UUID[Compendium.pf2e.equipment-srd.Item.Goo Grenade (Major)]</p>\n<p>You take persistent acid damage and a circumstance penalty to its Speeds from the clinging goo.</p>\n<p>The target can end any penalties, conditions, and persistent damage caused by the bomb by Escaping or spending a total of 3 Interact actions to pry themselves free of the ooze. These Interact actions don't have to be consecutive, and other creatures can provide the actions as well.</p>"
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Goo Grenade (Lesser)], @UUID[Compendium.pf2e.equipment-srd.Item.Goo Grenade (Moderate)], @UUID[Compendium.pf2e.equipment-srd.Item.Goo Grenade (Greater)], @UUID[Compendium.pf2e.equipment-srd.Item.Goo Grenade (Major)]</p>\n<p>You take a circumstance penalty to your Speeds.</p>"
},
"duration": {
"expiry": null,
Expand Down
2 changes: 1 addition & 1 deletion packs/equipment-effects/effect-hunters-brooch.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"name": "Effect: Hunter's Brooch",
"system": {
"description": {
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Hunter's Brooch]</p>\n<p>You grant that weapon the deadly d12 trait. Against undead, the weapon instead gains the fatal d12 trait.</p>"
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Hunter's Brooch]</p>\n<p>You grant the weapon the deadly d12 trait. Against undead, the weapon instead gains the fatal d12 trait.</p>"
},
"duration": {
"expiry": "turn-start",
Expand Down
2 changes: 1 addition & 1 deletion packs/equipment-effects/effect-hyldarfs-fang.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"name": "Effect: Hyldarf's Fang",
"system": {
"description": {
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Hyldarf's Fang]</p>\n<p>You gain the effects of @UUID[Compendium.pf2e.spells-srd.Item.Fly], @UUID[Compendium.pf2e.spells-srd.Item.Unfettered Movement], and @UUID[Compendium.pf2e.spells-srd.Item.Truesight] as well as fire resistance 20.</p>"
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Hyldarf's Fang]</p>\n<p>You gain fire resistance 20.</p>"
},
"duration": {
"expiry": "turn-start",
Expand Down
2 changes: 1 addition & 1 deletion packs/equipment-effects/effect-inflammation-flask.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"name": "Effect: Inflammation Flask",
"system": {
"description": {
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Inflammation Flask (Lesser)], @UUID[Compendium.pf2e.equipment-srd.Item.Inflammation Flask (Moderate)], @UUID[Compendium.pf2e.equipment-srd.Item.Inflammation Flask (Greater)], @UUID[Compendium.pf2e.equipment-srd.Item.Inflammation Flask (Major)]</p>\n<p>You gain weakness to acid, fire, and slashing damage for 3 rounds based on the bomb type.</p>"
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Inflammation Flask (Lesser)], @UUID[Compendium.pf2e.equipment-srd.Item.Inflammation Flask (Moderate)], @UUID[Compendium.pf2e.equipment-srd.Item.Inflammation Flask (Greater)], @UUID[Compendium.pf2e.equipment-srd.Item.Inflammation Flask (Major)]</p>\n<p>You gain weakness to acid, fire, and slashing damage.</p>"
},
"duration": {
"expiry": "turn-end",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"name": "Effect: Juggernaut Mutagen (Greater)",
"system": {
"description": {
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Juggernaut Mutagen (Greater)]</p>\n<p><strong>Benefit</strong> You gain a +3 item bonus to Fortitude saves and 30 temporary Hit Points. Whenever you are at maximum Hit Points for at least 1 full minute, you regain the temporary Hit Points. When you roll a success on a Fortitude save, you get a critical success instead.</p>\n<p><strong>Drawback</strong> You take a -2 penalty to Will saves, Perception checks and initiative rolls.</p>"
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Juggernaut Mutagen (Greater)]</p>\n<p><strong>Benefit</strong> You gain a +3 item bonus to Fortitude saves and 30 temporary Hit Points. When you roll a success on a Fortitude save, you get a critical success instead.</p>\n<p><strong>Drawback</strong> You take a -2 penalty to Will saves, Perception checks and initiative rolls.</p>"
},
"duration": {
"expiry": "turn-start",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"name": "Effect: Juggernaut Mutagen (Lesser)",
"system": {
"description": {
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Juggernaut Mutagen (Lesser)]</p>\n<p><strong>Benefit</strong> You gain a +1 item bonus to Fortitude saves and 5 temporary Hit Points. Whenever you are at maximum Hit Points for at least 1 full minute, you regain the temporary Hit Points.</p>\n<p><strong>Drawback</strong> You take a -2 penalty to Will saves, Perception checks and initiative rolls.</p>"
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Juggernaut Mutagen (Lesser)]</p>\n<p><strong>Benefit</strong> You gain a +1 item bonus to Fortitude saves and 5 temporary Hit Points.</p>\n<p><strong>Drawback</strong> You take a -2 penalty to Will saves, Perception checks and initiative rolls.</p>"
},
"duration": {
"expiry": "turn-start",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"name": "Effect: Juggernaut Mutagen (Major)",
"system": {
"description": {
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Juggernaut Mutagen (Major)]</p>\n<p><strong>Benefit</strong> You gain a +4 item bonus to Fortitude saves and 45 temporary Hit Points. Whenever you are at maximum Hit Points for at least 1 full minute, you regain the temporary Hit Points. When you roll a success on a Fortitude save you get a critical success instead, and your critical failures on Fortitude saves become failures instead.</p>\n<p><strong>Drawback</strong> You take a -2 penalty to Will saves, Perception checks and initiative rolls.</p>"
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Juggernaut Mutagen (Major)]</p>\n<p><strong>Benefit</strong> You gain a +4 item bonus to Fortitude saves and 45 temporary Hit Points. When you roll a success on a Fortitude save you get a critical success instead, and your critical failures on Fortitude saves become failures instead.</p>\n<p><strong>Drawback</strong> You take a -2 penalty to Will saves, Perception checks and initiative rolls.</p>"
},
"duration": {
"expiry": "turn-start",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"name": "Effect: Juggernaut Mutagen (Moderate)",
"system": {
"description": {
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Juggernaut Mutagen (Moderate)]</p>\n<p><strong>Benefit</strong> You gain a +2 item bonus to Fortitude saves and 10 temporary Hit Points. Whenever you are at maximum Hit Points for at least 1 full minute, you regain the temporary Hit Points.</p>\n<p><strong>Drawback</strong> You take a -2 penalty to Will saves, Perception checks and initiative rolls.</p>"
"value": "<p>Granted by @UUID[Compendium.pf2e.equipment-srd.Item.Juggernaut Mutagen (Moderate)]</p>\n<p><strong>Benefit</strong> You gain a +2 item bonus to Fortitude saves and 10 temporary Hit Points.</p>\n<p><strong>Drawback</strong> You take a -2 penalty to Will saves, Perception checks and initiative rolls.</p>"
},
"duration": {
"expiry": "turn-start",
Expand Down
2 changes: 1 addition & 1 deletion packs/equipment/fanged-major.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"containerId": null,
"description": {
"value": "<p>When etched with this rune, a weapon's hilt or haft becomes engraved with grooves that match the imprints of a wolf's teeth. By putting a <em>fanged</em> weapon in your mouth, you can transform into an animal.</p><hr /><p><strong>Activate</strong> <span class=\"action-glyph\">1</span> Interact (magical, polymorph, transmutation)</p><hr /><p><strong>Effect</strong> You transform into a Small or Medium animal that wields the <em>fanged</em> weapon in its jaws; the animal matches the animal you are most closely associated with (a lizardfolk would turn into a lizard, a kitsune into a fox, a deer instinct barbarian into a deer, etc.) or a wolf if no specific animal is applicable. While in this form, you can attack with the <em>fanged</em> weapon even though you don't have any hands. However, you can attack only with the <em>fanged</em> weapon and you don't have hands or the ability to hold items. For effects dependent on how many hands you are using to hold the item, such as the two-hand trait, you are holding the weapon in two hands. You can Dismiss this effect, and it ends automatically if you drop the <em>fanged</em> weapon (whether or not of your own volition).</p>\n<p>In animal form, you gain low-light vision, imprecise scent to a range of 30 feet, and a +10-foot item bonus to your Speed.</p>\n<p>@UUID[Compendium.pf2e.equipment-effects.Item.Effect: Fanged Rune Animal Form (Major )]</p>"
"value": "<p>When etched with this rune, a weapon's hilt or haft becomes engraved with grooves that match the imprints of a wolf's teeth. By putting a <em>fanged</em> weapon in your mouth, you can transform into an animal.</p><hr /><p><strong>Activate</strong> <span class=\"action-glyph\">1</span> Interact (magical, polymorph, transmutation)</p><hr /><p><strong>Effect</strong> You transform into a Small or Medium animal that wields the <em>fanged</em> weapon in its jaws; the animal matches the animal you are most closely associated with (a lizardfolk would turn into a lizard, a kitsune into a fox, a deer instinct barbarian into a deer, etc.) or a wolf if no specific animal is applicable. While in this form, you can attack with the <em>fanged</em> weapon even though you don't have any hands. However, you can attack only with the <em>fanged</em> weapon and you don't have hands or the ability to hold items. For effects dependent on how many hands you are using to hold the item, such as the two-hand trait, you are holding the weapon in two hands. You can Dismiss this effect, and it ends automatically if you drop the <em>fanged</em> weapon (whether or not of your own volition).</p>\n<p>In animal form, you gain low-light vision, imprecise scent to a range of 30 feet, and a +10-foot item bonus to your Speed.</p>\n<p>@UUID[Compendium.pf2e.equipment-effects.Item.Effect: Fanged Rune Animal Form (Major)]</p>"
},
"hardness": 0,
"hp": {
Expand Down

0 comments on commit be8fb0f

Please sign in to comment.