-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add advantage modes to abilities
objects
#4922
base: 4.2.x
Are you sure you want to change the base?
Conversation
5afcf18
to
0744b69
Compare
Wasn't there a discussion that for AEs to work properly you probably should split dis & adv so that way the cancelling can be parsed correctly? |
See the AdvantageModeField. |
Those are properties on the shared model schema – does this not have collisions across multiple actors of the same type? |
I don't see why - the field is reset when initialized, and actors don't share the same instance of a DataField. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good start 👍
…ove derived value `abilities.<x>.save` to `abilities.<x>.save.value`.
da1c939
to
bb31ffe
Compare
c1c65af
to
e5feb4a
Compare
(Built on top of #4890.)
Adds
system.abilities.<abilityId>.check.roll
and.save.roll
objects.Moves the derived
abilities.<abilityId>.save
value into.check/.save.value
with atoString
method for the deprecation period.(Also removes the
ability
property from theattributes.death
object.)TODO: