Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4866] Display nicer text for a dc-less passive skill enricher #4868

Open
wants to merge 1 commit into
base: 4.2.x
Choose a base branch
from

Conversation

roth-michael
Copy link
Contributor

Closes #4866

@arbron
Copy link
Collaborator

arbron commented Dec 12, 2024

Throw up a comment on the original issue so I can assign it to you

@krbz999
Copy link
Contributor

krbz999 commented Dec 12, 2024

If we added a highest property, we could support the use case in the issue explicitly, highlighting only those with the highest passive skill as a success.

@roth-michael
Copy link
Contributor Author

roth-michael commented Dec 12, 2024

Would be fairly trivial - I've got some local code for it now (for passive checks, at least). Would we want to change the enricher text for that so that "highest" was included in it, or just leave it?
image
i.e. should it say "highest passive Wisdom (Perception) score" automatically in the enricher (made with [[/skill perception passive highest format=long]])?
(Also: What should happen if both a dc and highest are provided - my gut says dc takes precedence and highest is ignored)

@krbz999
Copy link
Contributor

krbz999 commented Dec 12, 2024

(Also: What should happen if both a dc and highest are provided - my gut says dc takes precedence and highest is ignored)

I suppose it would be the highest that also passes the DC but imma let Arby sort out if this is a wanted feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for the DC of a passive skill enricher to be optional
3 participants