Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editionupdate #2681

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

editionupdate #2681

wants to merge 7 commits into from

Conversation

pheobeayo
Copy link

@pheobeayo pheobeayo commented Nov 17, 2024

Closes #

Introduced changes

-migrate scarb package to edition 2024_07

Checklist

@franciszekjob
Copy link
Collaborator

Hi @pheobeayo, please check out my last comment in #2651 :)

@pheobeayo
Copy link
Author

@franciszekjob Okay

Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't resolve the linked issue

snforge_std/Scarb.lock Outdated Show resolved Hide resolved
@franciszekjob
Copy link
Collaborator

@pheobeayo edition need to be changed in other packages as well, please verify it. If you have any questions, feel free to ask :).

@pheobeayo
Copy link
Author

@franciszekjob Kindly check my last commits, please. I made changes in some other packages. Kindly point out others I didn't pick out if all the changes haven't been made

@franciszekjob
Copy link
Collaborator

@pheobeayo there are many more packages, e.g. under crates/forge/tests/data.

@franciszekjob
Copy link
Collaborator

Hi @pheobeayo, please fix the errors on CI.

@franciszekjob
Copy link
Collaborator

Hi @pheobeayo do you need any help?

@pheobeayo
Copy link
Author

@franciszekjob I need help fixing the errors on the CI, I have been trying to resolve it since but I haven't gotten any headway, any clue?

@franciszekjob
Copy link
Collaborator

franciszekjob commented Nov 27, 2024

@franciszekjob I need help fixing the errors on the CI, I have been trying to resolve it since but I haven't gotten any headway, any clue?

Bumping edition results in occurring errors (which are visible on CI, example). Alternatively, you can open any package in which you bumped edition and run scarb build there - you will see these errors. In scope of this task, we should:

  1. bump edition (this is mostly done)
  2. resolve mentioned errors

Hope this helps you 😄

@pheobeayo
Copy link
Author

@franciszekjob I need help fixing the errors on the CI, I have been trying to resolve it since but I haven't gotten any headway, any clue?

Bumping edition results in occurring errors (which are visible on CI, example). Alternatively, you can open any package in which you bumped edition and run scarb build there - you will see these errors. In scope of this task, we should:

  1. bump edition (this is mostly done)
  2. resolve mentioned errors

Hope this helps you 😄

Okay, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants