Address some comments for PR #5 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
some of the comments will be addressed by the corresponding issues. I will also create an issue to add test cases and enable GH action to run the test cases |
gabe-l-hart
reviewed
Jun 24, 2024
yhwang
force-pushed
the
address-comments
branch
2 times, most recently
from
201d983 to
75ec4f7
Compare
gabe-l-hart
reviewed
Jun 25, 2024
- Add `image-pull-policy` in the ConfigMap to specify the imagePullPolicy of the job's pod - Add `pod-checking-interval` in the ConfigMap to set the pod checking interval - Update the Group and Kind of the CRD to `foundation-model-stack.github.com.github.com` and `LMEvalJob` - Refine the `checkScheduledPod` func of the controller based on the comment Signed-off-by: Yihong Wang <[email protected]>
|
thanks @gabe-l-hart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from #5
image-pull-policyin the ConfigMap to specify the imagePullPolicy of the job's podpod-checking-intervalin the ConfigMap to set the pod checking intervalfoundation-model-stack.github.com.github.comandLMEvalJobcheckScheduledPodfunc of the controller based on the comment