Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Jim and Alex dev image #388

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jbusche
Copy link
Collaborator

@jbusche jbusche commented Nov 6, 2024

Description of the change

This adds a dev stage to the Dockerfile which, when used with --target dev enables dnf, yum, git and the fms-hf-tuning dev tools.

Related issue number

Closes #1147

How to verify the PR

I built it two ways -

  1. First with the entire build that would generate the regular release image:
docker build --progress=plain -t fms-hf-tuning:jim_alex_dev_image2 . -f build/Dockerfile

1.2. I did a quick twistlock scan of this image, and it continues to look good.
1.3. I used this image to run a quick pytorchjob and it looked good.
1.4 TBD - Still need to test on a real GPU

  1. I built it with the dev target like this:
docker build --target dev --progress=plain -t fms-hf-tuning:realdev_image . -f build/Dockerfile

2.2 I did a quick twistlock scan of this image, and it finds vulnerabilities of the python, which is to be expected. (This is why we have a slimmed down release build, to avoid these vulnerabilities)
2.3 I got inside the image and it has the requested items that @anhuong was asking for:

podman run --rm -it localhost/fms-hf-tuning:realdev_image /bin/bash

and then:

[tuning@28888908315c app]$ which git
/bin/git
[tuning@28888908315c app]$ which dnf
/bin/dnf
[tuning@28888908315c app]$ which yum
/bin/yum

as well as the dev packages:

pip list |grep pack
packaging                24.1

pip list |grep ninja
ninja                    1.11.1.1

pip list |grep scikit
scikit-learn             1.5.2

pip list |grep boto
boto3                    1.35.55
botocore                 1.35.55

Was the PR tested

In progress

  • I have added >=1 unit test(s) for every new method I have added.
  • I have ensured all unit tests pass

Copy link

github-actions bot commented Nov 6, 2024

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@jbusche jbusche changed the title Jim/Alex dev image Jim-Alex dev image Nov 6, 2024
@jbusche jbusche changed the title Jim-Alex dev image Jim and Alex dev image Nov 6, 2024
@aluu317 aluu317 changed the title Jim and Alex dev image build: Jim and Alex dev image Nov 11, 2024
@github-actions github-actions bot added the build label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants