Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This adds a dev stage to the Dockerfile which, when used with
--target dev
enables dnf, yum, git and the fms-hf-tuning dev tools.Related issue number
Closes #1147
How to verify the PR
I built it two ways -
1.2. I did a quick twistlock scan of this image, and it continues to look good.
1.3. I used this image to run a quick pytorchjob and it looked good.
1.4 TBD - Still need to test on a real GPU
2.2 I did a quick twistlock scan of this image, and it finds vulnerabilities of the python, which is to be expected. (This is why we have a slimmed down release build, to avoid these vulnerabilities)
2.3 I got inside the image and it has the requested items that @anhuong was asking for:
and then:
as well as the dev packages:
Was the PR tested
In progress