-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor application structure, implement orchestrator with unary handling #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dan for all the 🌶️ changes. Loving all the refactors. This is much cleaner. I went through all the files except orchestrator.rs
and left some questions and comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 yay parallel calls! Thanks for all the cleanup here - just some q's
e8fb32c
to
0240ff6
Compare
…dling Signed-off-by: declark1 <[email protected]>
Co-authored-by: Evaline Ju <[email protected]> Signed-off-by: declark1 <[email protected]>
Signed-off-by: declark1 <[email protected]>
Signed-off-by: declark1 <[email protected]>
Signed-off-by: declark1 <[email protected]>
…ty. added rust-toolchain.toml. dropped unused methods. Signed-off-by: declark1 <[email protected]>
Signed-off-by: declark1 <[email protected]>
b425b41
to
c10a295
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: declark1 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks Dan
This PR refactors the application structure and implements various other changes tested during our initial PoC which we will continue to iterate on, including:
Orchestrator
with end-to-end unary task handling (and placeholders for streaming)DetectorClient
,NlpClient
,TgisClient
) to be higher-level with all methods (including streaming) fully implementedTODO:
Error
to appropriatehttp::StatusCode
with context