-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detector_id in response for orchestrator apis #278
Merged
evaline-ju
merged 18 commits into
foundation-model-stack:main
from
swith004:detector_id_1335
Jan 21, 2025
Merged
Add detector_id in response for orchestrator apis #278
evaline-ju
merged 18 commits into
foundation-model-stack:main
from
swith004:detector_id_1335
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swith004
requested review from
gkumbhat,
evaline-ju and
declark1
as code owners
January 15, 2025 19:18
Signed-off-by: Shonda-Adena-Witherspoon <[email protected]>
Signed-off-by: Shonda-Adena-Witherspoon <[email protected]>
Signed-off-by: Shonda-Adena-Witherspoon <[email protected]>
Signed-off-by: Shonda-Adena-Witherspoon <[email protected]>
…ults Signed-off-by: Shonda-Adena-Witherspoon <[email protected]>
swith004
force-pushed
the
detector_id_1335
branch
from
January 15, 2025 19:21
d531d50
to
860ece7
Compare
…r into detector_id_1335
2 tasks
Signed-off-by: Shonda-Adena-Witherspoon <[email protected]>
Signed-off-by: Shonda-Adena-Witherspoon <[email protected]>
evaline-ju
reviewed
Jan 16, 2025
Signed-off-by: Shonda-Adena-Witherspoon <[email protected]>
declark1
reviewed
Jan 16, 2025
…reverted nlp proto Signed-off-by: Shonda-Adena-Witherspoon <[email protected]>
declark1
reviewed
Jan 17, 2025
Update setting the detector_id in the TokenClassificationResult. Co-authored-by: Dan Clark <[email protected]> Signed-off-by: swith004 <[email protected]>
Signed-off-by: Shonda-Adena-Witherspoon <[email protected]>
declark1
reviewed
Jan 17, 2025
Signed-off-by: Shonda-Adena-Witherspoon <[email protected]>
evaline-ju
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly LGTM, I think some of the comment consistency was noted earlier but not applied throughout
Co-authored-by: Evaline Ju <[email protected]> Signed-off-by: swith004 <[email protected]>
Co-authored-by: Evaline Ju <[email protected]> Signed-off-by: swith004 <[email protected]>
Co-authored-by: Evaline Ju <[email protected]> Signed-off-by: swith004 <[email protected]>
Co-authored-by: Evaline Ju <[email protected]> Signed-off-by: swith004 <[email protected]>
Co-authored-by: Evaline Ju <[email protected]> Signed-off-by: swith004 <[email protected]>
declark1
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: foundation-model-stack/fms-guardrails-orchestrator#203
What does your PR do?
This PR changes the models for
DetectionResponse
,TokenClassificationResponse
, andContentAnalysisResponse
to include a detector_id along with the results, so that users can identify which detector provided the results (for instance, if there are multiple hap models, such as the cpu optimized version).How this was tested
This was tested locally, by modifying the config yaml to account for local certs, port-forwarding of os-detectors deployed on openshift, and locally run detectors (for hap). The following are the curl commands used to verify the changes to the orchestrator:
api/v2/text/generation-detection
api/v2/text/detection/generated
api/v2/text/detection/context
api/v2/text/detection/content
api/v1/task/classification-with-text-generation
api/v1/task/server-streaming-classification-with-text-generation