feat: added new category field in obligations #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deo002
reviewed
Jan 16, 2025
pkg/models/types.go
Outdated
| @@ -453,6 +477,11 @@ func (o *Obligation) BeforeUpdate(tx *gorm.DB) (err error) { | |||
| return fmt.Errorf("obligation classification must be one of the following values:%s", allClassifications) | |||
| } | |||
| } | |||
|
|
|||
| if err := validateCategory(o); err != nil { | |||
There was a problem hiding this comment.
If I do not pass category while updating an obligation(I want to update other fields), internal server error is raised.
This shouldn't be the case.
bhowmik94
force-pushed
the
feat/api/categoryField-obligation
branch
from
d2d163d to
38710ad
Compare
deo002
reviewed
Jan 21, 2025
| @@ -515,6 +539,11 @@ func (o *Obligation) BeforeUpdate(tx *gorm.DB) (err error) { | |||
| return fmt.Errorf("obligation classification must be one of the following values:%s", allClassifications) | |||
| } | |||
| } | |||
|
|
|||
| if o.Category != nil { | |||
There was a problem hiding this comment.
Why would you return error if o.Category is not nil?
You need to validate category field if it's not empty. It might be nil as it's a PATCH request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added category field with fixed enums for obligation GET api.
Updated the obligation POST, PATCH requests accordingly.
Validation for the new field is also added.
Fixes New field "Category" in obligations GET, PUT, POST #85
Submitter Checklist
References