Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(update): Exported constants from the search component #211

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

soham4abc
Copy link
Contributor

Description

Constants exported from the search component

Changes

pages/search/index.js

How to test

partly fixes: #108
Run the server and go to the search page to check it's functionality.

@soham4abc
Copy link
Contributor Author

PTAL @shaheemazmalmmd @GMishx @sjha2048

@GMishx GMishx added needs review Need code review needs test Needs testing labels Jun 7, 2022
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx GMishx removed the needs review Need code review label Jun 7, 2022
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx added ready PR is ready for merge and removed needs test Needs testing labels Jun 7, 2022
@GMishx GMishx merged commit e7a6576 into fossology:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor large components
2 participants