Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always initialize redirect_str to prevent memory leak #1029

Merged
merged 1 commit into from
May 1, 2024

Conversation

perazz
Copy link
Contributor

@perazz perazz commented May 1, 2024

Attempt to fix #1022.

Copy link
Member

@henilp105 henilp105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @perazz , looks good to me.

@zoziha zoziha changed the base branch from main to dependabot/github_actions/JamesIves/github-pages-deploy-action-4.6.0 May 1, 2024 07:54
@perazz
Copy link
Contributor Author

perazz commented May 1, 2024

@zoziha I don't know what branch dependabot/github_actions/JamesIves/github-pages-deploy-action-4.6.0 is for, but it seems like by changing to it, several older commits have been brought into this PR. should we go back to main instead?

@zoziha
Copy link
Contributor

zoziha commented May 1, 2024

Sorry, I was using my phone's github app to watch PR content and a screen mishit occurred, causing this change.

@zoziha zoziha changed the base branch from dependabot/github_actions/JamesIves/github-pages-deploy-action-4.6.0 to main May 1, 2024 08:28
Copy link
Contributor

@zoziha zoziha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@perazz perazz merged commit d9d5b53 into fortran-lang:main May 1, 2024
21 of 23 checks passed
@perazz perazz deleted the fix_mem_leak branch May 1, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory profiling reveals multiple "Conditional jump or move depends on uninitialised value(s)" errors
3 participants