Implement custom port option for LDAP communication #1853
+51
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOnAndOnlyZenomat
force-pushed
the
master
branch
from
bbeb566
to
1eeb23d
Compare
TheOnAndOnlyZenomat
force-pushed
the
master
branch
from
1eeb23d
to
c263d02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some custom AD implementations out there, like Univention, which might use a different than default port for LDAP communication. This implements an option to allow passing a custom port to the LDAP Connection call, as well as adapting the examples to satisfy the change.