Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the NTLMSSP_NEGOTIATE_SIGN flag to the NTLM CHALLENGE message returned by the SMB server. This is needeed for clients that generate a SPNEGO mechListMIC which require signing to be enabled on the NTLM context.
Some background information, a client that sends an NTLM token wrapped in a SPNEGO payload can set the mechListMIC but the MS-NLMP docs are unclear what the signature behaviour is without the
NTLMSSP_NEGOTIATE_SIGN
orNTLMSSP_NEGOTIATE_ALWAYS_SIGN
flags. I've interpreted it as signing isn't supported and thus themechListMIC
field cannot be computed. What should happen is if the client itself specified theNTLMSSP_NEGOTIATE_SIGN
flag then the challenge should also respond with it which this change does. This is backed up by the protocol docs for CHALLENGE_MESSAGE