Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NTLM SIGN flag for SMB Server #1826

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jborean93
Copy link

Adds the NTLMSSP_NEGOTIATE_SIGN flag to the NTLM CHALLENGE message returned by the SMB server. This is needeed for clients that generate a SPNEGO mechListMIC which require signing to be enabled on the NTLM context.

Some background information, a client that sends an NTLM token wrapped in a SPNEGO payload can set the mechListMIC but the MS-NLMP docs are unclear what the signature behaviour is without the NTLMSSP_NEGOTIATE_SIGN or NTLMSSP_NEGOTIATE_ALWAYS_SIGN flags. I've interpreted it as signing isn't supported and thus the mechListMIC field cannot be computed. What should happen is if the client itself specified the NTLMSSP_NEGOTIATE_SIGN flag then the challenge should also respond with it which this change does. This is backed up by the protocol docs for CHALLENGE_MESSAGE

If the client has set the NTLMSSP_NEGOTIATE_SIGN in the NEGOTIATE_MESSAGE the
Server MUST return it.

Adds the NTLMSSP_NEGOTIATE_SIGN flag to the NTLM CHALLENGE message
returned by the SMB server. This is needeed for clients that generate a
SPNEGO mechListMIC which require signing to be enabled on the NTLM
context.
@anadrianmanrique anadrianmanrique self-assigned this Oct 10, 2024
@anadrianmanrique anadrianmanrique added the in review This issue or pull request is being analyzed label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review This issue or pull request is being analyzed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants