New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debug argument placement #2

Merged

raoulstrackx merged 1 commit into master from ns/RTE-215

Jan 10, 2025

Contributor

nshyrei commented Jan 9, 2025 •

edited

Loading

Corrects the logic that sets debug (https://github.com/fortanix/salmiac/blob/f420ca867761a0ad1b12249f90cab814156d3f15/api-model/src/converter.rs#L153) value in Salmiac conversion request. Current logic tries to set field debug in https://github.com/fortanix/salmiac/blob/f420ca867761a0ad1b12249f90cab814156d3f15/api-model/src/converter.rs#L196 which doesn't have a field with such name. In particular this change fixes TestMysql application test.


          - fixed arg placement

89c69c5

nshyrei added the bug label

nshyrei requested review from aditijannu and raoulstrackx

January 9, 2025 14:11

nshyrei self-assigned this

raoulstrackx approved these changes

View reviewed changes

raoulstrackx merged commit 5abda41 into master

1 check failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug