Adding js/ts util method to verify JWT's generated by a scanner #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robert-H-Leonard
commented
Sep 5, 2022
Robert-H-Leonard
changed the title
|
In terms of E2E testing are there any other ways to test without having to manually deploy a bot? |
E2E would imply that we are testing the whole stack (and therefore deploying a bot). we can definitely unit test these methods (just created a ticket to add unit tests for SDK methods #213) |
Robert-H-Leonard
changed the title
| @@ -7,7 +7,7 @@ | |||
| from .trace import Trace, TraceAction, TraceResult | |||
| from .event_type import EventType | |||
| from .network import Network | |||
| from .utils import get_json_rpc_url, create_block_event, create_transaction_event, get_web3_provider, keccak256, get_transaction_receipt, get_alerts, fetch_Jwt_token, decode_Jwt_token | |||
| from .utils import get_json_rpc_url, create_block_event, create_transaction_event, get_web3_provider, keccak256, get_transaction_receipt, get_alerts, fetch_Jwt, decode_Jwt | |||
There was a problem hiding this comment.
fetch_jwt, decode_jwt*
haseebrabbani
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature work
Testing
Manual/Local testing
In order to validate the verification locally I generated a JWT locally and called the verify method during the initialization of my bot running locally. B/c this bot isn't deployed to validate the happy path locally, during testing I found a bot and an scanner who were linked and hardcoded their addresses in the call to
areTheyLinkedto make sure the smart contract call was valid: