Ref: poly (de)compress: use a single loop counter #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfaoliveira
added a commit
to formosa-crypto/libjade
that referenced
this pull request
Feb 9, 2024
tfaoliveira
added a commit
to formosa-crypto/libjade
that referenced
this pull request
Feb 9, 2024
tfaoliveira
reviewed
Feb 9, 2024
There was a problem hiding this comment.
There was a small increase in the cycle count (not expected but it was happening consistently) so I took a deeper look.
What do you think about integrating the changes from here: formosa-crypto/libjade@bb8569c
The performance is the following (i7 11700K) (libjade commits):
## before (@ commit 76e3b53c827d32eb62aeca05f668d8fa58467b5f)
keypair , 301830, 301768, 301834
enc , 352738, 352580, 352722
dec , 424528, 424658, 424658
## after (this PR) (@ commit dd636716b7fe4f342c81276ea01f3c0afc1d0089)
keypair , 302338, 302270, 302212
enc , 352902, 353038, 353100
dec , 424964, 425180, 425036
## after scheduling (@ commit bb8569c01597338148800210de5aa2b512f783c6)
keypair , 301910, 301872, 301918
enc , 351928, 352028, 352158
dec , 424186, 424290, 424276
|
Thanks, I’ll do it ASAP. |
Co-authored-by: Tiago Oliveira <[email protected]>
vbgl
force-pushed
the
ref-poly-compress-decompress-onecounter
branch
from
9827d66 to
27d9a26
Compare
Rixxc
pushed a commit
to formosa-crypto/libjade
that referenced
this pull request
Apr 17, 2024
Rixxc
pushed a commit
to formosa-crypto/libjade
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: https://github.com/vbgl/hakyber/actions/runs/7845618780