gen-matrix: clearer loop condition #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfaoliveira
added a commit
to formosa-crypto/libjade
that referenced
this pull request
Feb 8, 2024
tfaoliveira
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
before (replace lea by add) formosa-crypto/libjade@318662c
ref/ avx2/
keypair , 304170, 87756
enc , 355714, 85380
dec , 427134, 86070
after (gen matrix) formosa-crypto/libjade@a5aeef9
ref/ avx2/
keypair , 302388, 85370
enc , 353214, 82948
dec , 425202, 84056
code looks good, performance is improved in i7 11700K.
|
Thanks for confirming the performance improvement. |
Rixxc
pushed a commit
to formosa-crypto/libjade
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearer code, simpler proof, and better performances.