Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.21.x] FIO-8195: Fixed visibility of nested form in pdf with viewer:show tag #5921

Open
wants to merge 1 commit into
base: 4.21.x
Choose a base branch
from

Conversation

roma-formio
Copy link
Contributor

@roma-formio roma-formio commented Nov 22, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8195

Description

Issue: PDF generation can use the viewer:show tag to display hidden components. However, the isHidden method in the Form component does not consider the options.show property (which checks the viewer:show tag). As a result, the subform is not loading at all.

Solution: Update the isHidden method to take into account the options.show property.

How has this PR been tested?

Manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant