Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9314: made select data property a hidden component and changed hidden component empty value to null #5910

Conversation

ZenMasterJacob20011
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9314

Description

What changed?

Changed the selectData property to be a hidden component and made hidden components empty values be null

Why have you chosen this solution?

The selectData property is a property that needs to be on the select component in certain cases but does not need to be shown or modified directly by a user. Making it a hidden component removes it from the edit form and making the hidden component have a empty value of null allows tests to pass. The reason why I thought it was ok to change the hidden component empty value to null is because the hidden component is usually used to store some kind of meta data in the form. This means the hidden component can be used to store any type of data such as Strings, Numbers, Objects, etc. It made more sense to me for the hidden component to have an empty value of null because having an empty value of '' (empty string) implies that you should only use hidden component to store string values.

Breaking Changes / Backwards Compatibility

N/A

Dependencies

N/A

How has this PR been tested?

Manually tested

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold merged commit 417014a into master Nov 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants