Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-6632: Automate @formio/js updates to formiojs.test-form.io #5666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryanformio
Copy link
Contributor

@ryanformio ryanformio commented Jun 28, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-6632

Description

  1. Noticed a few things weren't building quite right. The SemVer in the package.json was not being updated automatically during build process. Created a script that will run everytime yarn build is called to get the tag from git and update pacakge.json. Should ensure correct time every build.
    https://github.com/formio/formio.js/actions/runs/9700333835 <- Happened to see that the version was v5.0.0-rc60 but did not see the version on the CDN. Saw v5.0.0-rc.59 and this was because the package.json version read 5.0.0-rc.59.
  2. Noticed some differences in the CDN files based on looking at the artifact being distributed on GH Pages.
  3. Added updates to the release.yml to include the yarn install, yarn build, yarn release, and yarn invalidate to updates trigger properly in pipeline.

Why have you chosen this solution?

Was asked to provide some testing steps for previous issue FIO-6632 per Dane and noticed some issues in the process.

Dependencies

n/a

How has this PR been tested?

Pushed the updates to test CDN to test commands manually.
https://formiojs.test-form.io/5.0.0-rc.60/

Link to steps documented in Confluence -> https://formio.atlassian.net/wiki/x/AQCkCQ

image

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@ryanformio ryanformio requested a review from travist June 28, 2024 19:06
@ryanformio ryanformio marked this pull request as ready for review June 28, 2024 19:06
@travist
Copy link
Member

travist commented Jul 19, 2024

I don't think we should be automatically updating the symver automatically. I am fine with DEV tags, but there may be some bad side effects of this releasing the RC versions automatically. It may also cause issues with our build script. Is this really necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants