FIO-9467: Fix rendering table component in wizard #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanbond
requested changes
Dec 30, 2024
src/utils/formUtil/eachComponent.ts
Outdated
| @@ -43,7 +43,8 @@ export function eachComponent( | |||
| eachComponent(column.components, fn, includeAll, compPaths, component), | |||
| ); | |||
| } else if (info.hasRows) { | |||
| component.rows.forEach((row: any) => { | |||
| const comp = component.component || component; | |||
There was a problem hiding this comment.
Can you explain this change? Is this table component specific? If so, it might be beneficial to have a info.isTable or something to make it explicitly clear that we have an edge case with the table component
There was a problem hiding this comment.
I might actually need to revisit this, since I've noticed jumping between versions that this bug is something to do with the renderer updates, rather than core. Will put it to draft state for now
| @@ -0,0 +1,92 @@ | |||
| export default [ | |||
There was a problem hiding this comment.
Can we name these files more descriptively?
|
@brendanbond refactored the solution, appeared to be another part of code that initially broke it |
brendanbond
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9467
Description
What changed?
eachComponentWhy have you chosen this solution?
Use this section to justify your choices
Breaking Changes / Backwards Compatibility
Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility
Dependencies
Use this section to list any dependent changes/PRs in other Form.io modules
How has this PR been tested?
Automated test added
Checklist: